PSZabbix
PSZabbix copied to clipboard
Add Maintenance cmdlets, unit tests, refactor to folders
Added maintenance functions (New \ Get \ Remove) Added unit tests for the functions needed immediately and refactored to separate files to simplify debugging and maintenance. Fixed small bugs as the unit tests exposed them. Moved the sprawl of files into subfolders to keep the top level clean. Refactored the Zbx prefix into the function declarations to simplify maintenance. Added install\uninstall scripts to simplify dev and testing. Moved existing test into end-to-end test folder.
Thanks for the huge work. I like the "one method per file" change. However, I think hard coding the prefix is a regression - I have actually been in contexts where we had prefix collisions (not with this module, but I am now prudent on that matter). So this is one change I would like to revert.
are there any plans to add new interface cmdlet? Or how it working now to add an interface to a host?
Hi @marcanpilami,
we're using your module because it's handy and more "powershelly" (thanks!) than others we've hade a look on. I would really appriciate to see @doglefts maintanance-extensions going into the official branch.
What's left? Can I assist you in fixing those things? Additionally I would like to make it able to run under Linux PS-Core. As a start I adopted the pester tests to v5 syntax (in a local branch). Thus I could start to assist.
Regards, Wolfgang