Marc Bolinches
Marc Bolinches
> * I see that you decided not to implement conversion back and forth on the backend and did this inside webapi. Do you plan to keep it this way?...
> Lots to think about of what this this will enable! It'd be interesting to do a demo of a standard basic CMOS electronic device (eg. MOScapacitor, etc) for that...
All I've done so far is to introduce a validator that checks that data can be interpolated in each of the dimensions.
> Thanks @marc-flex I think this is looking pretty good, just a few minor tweaks and also we should see if we want to apply this validator to all `DataArray`...
@tylerflex I have tried several things. With the solution you mentioned (`val.interp_like(val.isel({val.dim: 0}))`) tests kept failing. So I have modified it to use an array of values from within the...
> Thanks @marc-flex just FYI, this PR #1681 changed some of the tests in pre/2.7 so it looks like you'll need to rebase against that branch and fix any conflicts...
> Just one comment: custom datasets are validated in `CustomMedium`. Shall we validate all other types of custom materials as well, e.g. CustomPoleResidue, CustomLorentz, etc.? You're opening Pandora's box here....
> > > Just one comment: custom datasets are validated in `CustomMedium`. Shall we validate all other types of custom materials as well, e.g. CustomPoleResidue, CustomLorentz, etc.? > > >...
@tylerflex @momchil-flex I have rebased and I thought everything would be OK from my side but it fails the "latest" test. Do let me know how to fix this.
Not sure why poetry didn't complain about that when I committed the squash+rebase. I think it's all good now