Mao Suhan comments

Repositories
Issues
Comments

Results 3 comments of


                                            Mao Suhan

[FLINK-33817][flink-protobuf] Set ReadDefaultValues=False by default in proto3 for performance improvement

@sharath1709 Thanks for the contribution. I'll also help to look into this PR also and I expect to finish it this week. cc @libenchao

[FLINK-33817][flink-protobuf] Set ReadDefaultValues=False by default in proto3 for performance improvement

LGTM now

[FLINK-33817][flink-protobuf] Set ReadDefaultValues=False by default in proto3 for performance improvement

> ## What is the purpose of the change > **Background** > > The current Protobuf format [implementation](https://github.com/apache/flink/blob/c3e2d163a637dca5f49522721109161bd7ebb723/flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/deserialize/ProtoToRowConverter.java) always sets ReadDefaultValues=False when using Proto3 version. @sharath1709 I think the description...