manx

Results 40 comments of manx

Sadly this has been merged with a totally broken commit on top of it, see .

Building v0.11-rc3 fails for me with ``` [...] g++ -Wall -Wextra -Werror -O3 -I../include -D_FILE_OFFSET_BITS=64 -std=c++11 -Wold-style-cast -Wno-missing-field-initializers -M -MF openat2.dep -MT openat2.o openat2.cc In file included from openat2.cc:1: ../include/crucible/openat2.h:4:10:...

> > [...Ubuntu 20, kernel 5.15, kernel headers 5.4...] > > It turned out to be not too painful to add compatibility code for older headers, similar to what bees...

> > > It turned out to be not too painful to add compatibility code for older headers, similar to what bees already does for btrfs, so I pushed a...

This makes the tests fail: ``` manx@sagnix:~/projects/minimp3/minimp3.git$ ./scripts/test.sh ~/projects/minimp3/minimp3.git ~/projects/minimp3/minimp3.git rate=48000 samples=2304 max_diff=0 PSNR=99.000000 vectors/ILL2_center2.bit exited with code=0 rate=48000 samples=2304 max_diff=0 PSNR=99.000000 vectors/ILL2_dual.bit exited with code=0 rate=48000 samples=2304 max_diff=0 PSNR=99.000000...

> curious as to if it is fixed on what I just pushed today? i had a typo Yes, the tests pass now.

All fair, but what should client applications actually do? I would rather not have to invent a magic value myself that happens to be adequate for FLAC 1.5.0, but might...

I guess we need some numbers. build script (current git master): ``` #!/usr/bin/env bash set -e ./autogen.sh ./configure --enable-static --disable-shared make make check ``` test corpus (44100Hz stereo 16bit): *...

* system C: AMD Ryzen 7 6800U (8C/16T) (Zen3+), 24GB RAM, GCC 14.1, MSYS2-MINGW64 on Windows 11 24H2 ![Image](https://github.com/user-attachments/assets/dd4451f3-043c-48a0-9f0a-0acc075e4873) [C-results.txt](https://github.com/user-attachments/files/19323563/C-results.txt) Without the WSL2 VM overhead, it scales better on that...

While I would also like to see reduced stack usage, the approach implemented here does not really work: When using minimp3 in a separate translation unit (i.e. without `MINIMP3_IMPLEMENTATION` defined),...