Marc Nuri

Results 677 comments of Marc Nuri

Let's discuss this tomorrow. I'm not sure about the current approach and how does this might converge with users relying on commons-collections on their projects.

In general, I'd try to move away from Pluralize and rely on the real API plural which differs from the output of Pluralize.toPlural on many occasions.

> I agree but there are cases where you don't get a choice and you'd still want to get the default plural version that is computed by Fabric8, without having...

> Ideally, you'd get the plural from the resource class but you might not have the resource class, only the GVK. Right now we should be doing that by querying...

> but it's just not possible when you perform that processing at build time and/or you might not be connected to the target cluster. Why would you need the plural...

> To generate RBACs which happens at build time. More specifically, when the user is using `GenericKubernetesResource` for secondary resources, the processor might only get the GVK for the resource,...

> use the same logic as the client to determine the plural when it's not provided or otherwise unavailable, as a best effort kind of thing _I'm repeating this just...

> Is this a known flaky test? Yes. There are a couple of flaky tests. Some have become more flaky now that everything is based on Vert.x.

> @manusa Could you give me one concrete example how you would like the asserts to look like? I'm struggeling a bit with the deep nested structures and the many...

Also, considering the complexity of the Test suite, it might be better to create multiple PRs instead of a single one with all the changes at once.