kubernetes-client icon indicating copy to clipboard operation
kubernetes-client copied to clipboard

chore (deps) : Move `io.fabric8:zjsonpatch` as a module in Fabric8 kubernetes Client

Open rohanKanojia opened this issue 1 year ago • 3 comments

Description

Fix #5480 Fix #3489

Supersedes closes #4700

Currently, we rely on outdated io.fabric8:zjsonpatch dependency instead of the upstream com.flipkart.zjsonpatch:zjsonpatch dependency. The main issue is that the upstream repository depends on org.apache.commons:commons-collections4 .

  • Add a new module zjsonpatch that would directly include com.flipkart.zjsonpatch:zjsonpatch dependency excluding org.apache.commons:commons-collections4.
  • Port required Apache Commons Collections4 method ListUtils.longestCommonSubsequence and related classes inside zjsonpatch module

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change
  • [X] Chore (non-breaking change which doesn't affect codebase; test, version modification, documentation, etc.)

Checklist

  • [X] Code contributed by me aligns with current project license: Apache 2.0
  • [ ] I Added CHANGELOG entry regarding this change
  • [X] I have implemented unit tests to cover my changes
  • [ ] I have added/updated the javadocs and other documentation accordingly
  • [ ] No new bugs, code smells, etc. in SonarCloud report
  • [ ] I tested my code in Kubernetes
  • [ ] I tested my code in OpenShift

rohanKanojia avatar Aug 14 '24 13:08 rohanKanojia