Manu Gupta

Results 33 comments of Manu Gupta

@AkihiroSuda @Zheaoli I tried this issue a few weeks back, where I got stuck was on how to clean up the resources. The approach that I tried was invoking the...

In this case. ``` === RUN TestRunWithJsonFileLogDriver run_test.go:237: the maximum number of old log files to retain exceeded 2 files, got: [] --- FAIL: TestRunWithJsonFileLogDriver (3.44s) ``` https://github.com/containerd/nerdctl/runs/7319449412?check_suite_focus=true

I got another failure: https://github.com/manugupt1/nerdctl/runs/7366257926?check_suite_focus=true#step:5:695 Test summary: https://github.com/manugupt1/nerdctl/actions/runs/2679791706

I think we should log and let users know users with log.Info not log.Warn. We should not removing logging though as it is nerdctl specific behavior.

This is fixed. Can we close this now

I would like to try working on fluentbit driver if that is fine and no one is working on it.

@fahedouch do you have a draft PR for local that I can take inspiration from for external driver?

> @manugupt1 is there any update about this issue? Sorry, been busy with work a lot. So, I have not made much progress

@AkihiroSuda @fahedouch @Zheaoli Should we close this as third party support is open or keep it open for inbuilt drivers?