Manuel Zahariev

Results 62 comments of Manuel Zahariev

I leave it up to you whether to move ahead with this or dig more (not hopeful :disappointed: )

That being said, Andreas just seems to have changed the rules a bit with #6496. ...and it seems that `DOM::Text` is no longer weakable :face_with_head_bandage: . I think `GC::Weak` is...

Outdated I have left `OwnPtr list_of_text_nodes` (and not made it `NonnullOwnPointer` or the `Vector` itself), since I avoid the list creation overhead unless `needs_reversed_counter_fixup`. - Reasoning: Some pages have lots...

Simple rebase bump after this PR was marked as stale. Will probably let it lapse next time if there is no interest. I feel like I dealt with all comments.

Same issue for me: - `gcc`; Ubuntu-24.04 guest (30 threads; KVM; `llvmpipe`) on Ubuntu 22.04 host; beefy laptop; Nvidia GEForce RTX 4060 + nouveau - Created #6322 then closed as...

Seems like two separate issues: - `vkCreateDevice` fails with `VK_ERROR_EXTENSION_NOT_PRESENT` (likely refers to `VK_EXT_IMAGE_DRM_FORMAT_MODIFIER_EXTENSION_NAME`) and triggers `Vulkan context creation failed: Logical device creation failed` on start. As a result, the...

@rcorsi Great! Three thoughts: > if the shareable vulkan image feature is [not] supported [...] telling them to recompile (1) It would be totally awesome if this could be dealt...

> what is "next_tree_slice" in commit message? I can't find anything with this name in our codebase. True :smile: I define it earlier in the commit message : > descendents,...

Suggestions: 1. Two checks may be optimal: - At build time: avoid the runtime "failed Vulkan context creation" overhead every time you open a tab. - At runtime: protect against...