Manuel Zahariev

Results 62 comments of Manuel Zahariev

Thank you for the thoughtful review @trflynn89 .

This is no longer reproducible (on add380d6e2). I recommend closing (fixed) cc @ADKaster . ``` $ curl -d '{"capabilities":{}}' http://127.0.0.1:8000/session {"value":{"sessionId":"5b258425-c3dd-4f03-8355-a1f7a2040d69","capabilities":{"browserName":"ladybird","browserVersion":"1.0","platformName":"linux","acceptInsecureCerts":false,"setWindowRect":true,"userAgent":"Mozilla/5.0 (Linux; x86_64) Ladybird/1.0","strictFileInteractability":false,"ladybird:headless":false,"proxy":{},"unhandledPromptBehavior":"dismiss and notify","pageLoadStrategy":"normal","timeouts":{"script":30000,"pageLoad":300000,"implicit":0}}}} ``` ``` $ curl...

Cannot repro in 6f1710121d. It fixed itself?

#3882 implements "simple" site isolation for "sites" (TLD + one level, as in the chromium description). Nice! Since this is done in `Navigable::navigate`, it should also apply to iframes? Would...

Looking at this. I may have a PR in the next couple of days. The plumbing seems to be mostly there: - `LibCrypto/BigInt/Algorithms/Division.cpp : divide_without_allocation` - encoding to `double` promises...

> [...] test262 [...] Thanks! Helps. Looking at the failing tests, I think: - some of them should be covered by the division FIXME :point_left: my upcoming PR (looks promising)...

#2989 has integrated OpenSSL into the Ladybird codebase. [BIGNUM](https://github.com/openssl/openssl/tree/master/crypto/bn) may be a more natural long-term option.

> Sorry about that! 😅 Let me know if anything is confusing. Not at all. Looks awesome :sunglasses: ! - Originating counter as `AbstractElement` is a lot better -- don't...

@AtkinsSJ Thank you very much for your review! I am grateful for the thoughtful comments + realize it was not easy. Click for details. - The name `reversed` in the...

> [...] I'm a bit unsure about the approach [...] a lot of little function calls to fix things up, scattered around, and that makes it easy for someone [...]...