Antariksh Mahajan comments

Results 9 comments of


                                            Antariksh Mahajan

Custom type parsers do not run for multi-line statements

@charmander thanks for responding! This is just a simplified example for the sake of illustrating the bug. I actually encountered this bug as a user of `sequelize`, which does exactly...

fix: use existing Result types for new Result

Got it, I'll add a test. I'll try to find some time to work on it over the next couple of days.

fix: use existing Result types for new Result

@charmander I added a test for this case in 3c1a7d1

fix: use existing Result types for new Result

Just checking, are there any further changes I should make? No rush, just wondering if there's anything I can do to help!

fix: use existing Result types for new Result

Seems like tests are failing for `pg-native` in NodeJS 20 and 22. Do you think this is related to the changes, or might it be that the tests are flaky?...

fix: use existing Result types for new Result

Hey @brianc @charmander! The tests are passing for me locally on both Node 20 and 22 (see screenshots). Do you think it might be worth rerunning the actions to see...

fix: use existing Result types for new Result

@brianc Done!

findOrCreate returns string when column type is PostgreSQL array

Opened a fix in `node-postgres`: https://github.com/brianc/node-postgres/pull/3310

findOrCreate returns string when column type is PostgreSQL array

Fixed in `[email protected]`