Mansoor Ahmed comments

Results 32 comments of


                                            Mansoor Ahmed

Calling `callMountedFormComponentAction` with arguments does not pass the arguments

I tried to debug this and seems like the Action arguments are flushed out when following methods are called in `HasFormComponentActions` Trait: `getMountedFormComponentActionForm` ```php // Line No: 57 $form =...

Calling `callMountedFormComponentAction` with arguments does not pass the arguments

@zepfietje @danharrin Should I send a PR to move down the `$action->mergeArguments($arguments);` and call it after the above mentioned methods? I am not quite sure if the arguments are also...

Calling `callMountedFormComponentAction` with arguments does not pass the arguments

Hey @danharrin Could you please help me what could be a work around for now. Maybe some other way to handle this kind of requirement?

Calling `callMountedFormComponentAction` with arguments does not pass the arguments

I apologise for not being patient. Thanks for taking time ❤️

Calling `callMountedFormComponentAction` with arguments does not pass the arguments

Thank you so much for fixing this one.

Adding `updated_at` to `$dontVersionable` results in error when calling `diff()`

> I don't really want to track `updated_at`, so I added it to the `$dontVersionable` variable in the model, however when calling the `diff()` method it gives me the following...

Adding `updated_at` to `$dontVersionable` results in error when calling `diff()`

@overtrue Seems like there are two issues with snapshot. 1) Initial version does not contain any attributes, so its always null 2) New versions are stored even though the $versionable...

Adding `updated_at` to `$dontVersionable` results in error when calling `diff()`

@overtrue I think maybe this is happening because user aaded the DIFF strategy initially but then switched to Snapshot? So one version which was created using DIFF might have a...

Adding `updated_at` to `$dontVersionable` results in error when calling `diff()`

I am able to reproduce. Its the DIFF strategy which adds non $versionable attributes

Adding `updated_at` to `$dontVersionable` results in error when calling `diff()`

@overtrue I beleive there shouldnt be the DIFF strategy it should only be snapshot. which stores all attributes by default unless you specifiy $versionable.