Simon Li

Results 655 comments of Simon Li

Hi :wave: This is an old issue and the repository has been updated. If you have more questions please use the [Jupyter community forum https://discourse.jupyter.org/](https://discourse.jupyter.org/).

I think this is worth trying on one of the proposed enum types first, so we can evaluate tradeoffs in how they're implemented. E.g. `__str__` can be overridden to return...

Maybe we should make `_get_image_basename_and_tag` part of the Registry class so it can be specialised for particular registry implementations instead of trying to have it work with everything.

Can you suggest a `fullname,basename,tag` tuple we could add to this test? https://github.com/jupyterhub/binderhub/blob/31149279def7e0183c6b4be76a7b1e5b1d016361/binderhub/tests/test_builder.py#L6-L37 You can anonymise it, but ideally make it as close as possible to a real case.

Most of this was done in https://github.com/jupyterhub/binderhub/pull/1531 ! There are a few follow-ups but the key requirement (run without Docker) is done!

Yes! It requires https://github.com/manics/binderhub-container-registry-helper to be deployed. This increases the deployment complexity, but avoids needing vendor specific requirements and code in BinderHub, simplifying maintenance and testing. Though you've reminded me...

In a recent PR @sgaist and I discussed the idea of replacing the docker/podman file socket with a tcp. This requires some care with routing to preserve the affinity between...

There's an open PR: https://github.com/jupyterhub/binderhub/pull/1628

I quite like the idea of having a single property to handle both tcp ports and unix sockets. This is similar to how you set the docker host (`unix:///var/run/docker.sock`, `tcp://localhost:12345`),...

> Using the proxy name alias doesn't seem to get resolved, whereas specifying the port number explicitly does seem to work. The proxy name should `server:8888/` work with dynamically allocated...