Simon Li

websockify also intercepts the VNCserver's TCP socket bind request (e.g. to 5901), transparently changes the internal library call so that the VNCserver binds to ``, and websockify listens on the...

We don't have a weekly time slot, are you thinking of a different team? Regardless, if you edit your message to include the date/time that'll make it clear to everyone,...

This will hopefully(!) be fixed when https://github.com/oschuett/appmode/pull/65#issuecomment-1466218531 is released appmode isn't pinned: https://github.com/binder-examples/appmode/blob/ef9cb16bf8002bde4a2dc39c8c40ed7ebbeab971/environment.yml#L5 but since the image may be cached the most reliable option will be to set a minimum...

Unfortunately installing websockify from pypi does not currently include the compiled library that wraps the VNCserver. If you install websockify from conda the library is included. See for example https://github.com/yuvipanda/jupyter-desktop-server/blob/master/environment.yml

I like the idea of using labels too, it avoids sending comment notifications to everyone.

https://github.com/jupyterhub/jupyterhub/pull/4564

I agree, especially since pass-through configuration means any docs would initially duplicate (and inevitably later lag behind) the existing OAuthenticator docs

These annotations are specific to your ingress controller so they can't be hard-coded. For example, ingress-nginx (not the same as nginx-ingress!) supports websockets by default https://kubernetes.github.io/ingress-nginx/user-guide/miscellaneous/#websockets

Even with a two stage update (over two major versions) some people won't have updated, so we'll still need some documentation for people who skip a major release.

My vote is to put this in a new repository/package that has oauthenticator as a dependency, collaboratively work on it there, test it in production, and then review whether some...