Phuc Nguyen comments

Results 6 comments of


                                            Phuc Nguyen

Forward environment variables to spawned processes in WP_CLI::launch()

Thanks a lot for the review and the kind words! 🙌 Yes, adding Behat coverage makes sense here. My plan is to: - Add a scenario that verifies the forwarded...

Forward environment variables to spawned processes in WP_CLI::launch()

Hi @swissspidy! 👋 Quick update — I’ve just pushed the Behat coverage we discussed. 😊 The new feature file is: `features/launch-env-forwarding.feature` It includes two scenarios that directly exercise the behaviour...

feat(db): add robust support for WP_CLI_MYSQLDUMP override with fallback handling

Thanks for the suggestions! I've applied the refactor to use early returns and added a debug message for the non-executable absolute-path case. I also updated the final log line to...

Early filter invalid hosts in wp_http_validate_url()

Thanks for the review! I’ve updated the patch to address all the points raised: - hostname validation now only applies when the host is not an IPv4 address - removed...

Early filter invalid hosts in wp_http_validate_url()

Thanks for the feedback! I’ve updated the patch to address all the points: - switched the check to `extension_loaded( 'filter' )` as suggested - kept IPv4 handling separate to avoid...

Early filter invalid hosts in wp_http_validate_url()

Thanks everyone for the detailed feedback and edge-case examples. I’ve updated the hostname validation logic to avoid regressing legacy hosts that include underscores in subdomains (e.g. Blogspot), while still rejecting...