Aman Mangal comments

Results 29 comments of


Aman Mangal

[QUESTION]: Patch to fix for Windows compile here

Could you raise a PR? I wouldn't be against merging it if the CI is happy.

fix(level-handler): level handler - key with zero version can never be found

@agfn could you rebase please?

Why v3 doesn't have FileIO mode

This seems related to https://github.com/dgraph-io/badger/issues/1841 and we plan to look into this next month.

adding txn.upsert rough draft

@Kingloko We do not plan to add this in the library but we could add this as a test or an example. If you could raise a PR with that,...

Remove github.com/pkg/errors dependency

@anderseknert could you rebase on latest main? I will be able to merge this change then

[Non-hashed key values in Item]: onEvict should send the non hashed key values

We do not store the key in ristretto, if you care about the key, you could store it in the value.

chore(deps): bump github.com/docker/docker from 24.0.5+incompatible to 24.0.9+incompatible

@dependabot please rebase

fix: update maxHeaderSize

@joshua-goldstein could you write a test for it so that in case something changes, the test fails. We also should figure out what are the cases when the header size...

fix: update maxHeaderSize

I am closing this PR in lieu of #1877. Once again, thank you for your contribution