badger icon indicating copy to clipboard operation
badger copied to clipboard

Published 20 hours ago • verified publisher icon dgraph-io

fix: update maxHeaderSize

Open microyahoo opened this issue 2 years ago • 2 comments

Based on pkg-constants, the maxHeaderSize should be 22=5+5+10+1+1, which is discussed on Why is the maxHeaderSize 21 and not 22?

Signed-off-by: Liang Zheng [email protected]

microyahoo avatar Aug 14 '22 16:08 microyahoo

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 14 '22 16:08 CLAassistant

@jarifibrahim @manishrjain @MichelDiz PTAL, thanks.

microyahoo avatar Aug 29 '22 03:08 microyahoo

@joshua-goldstein could you write a test for it so that in case something changes, the test fails. We also should figure out what are the cases when the header size could become 22.

mangalaman93 avatar Feb 07 '23 02:02 mangalaman93

I am closing this PR in lieu of #1877. Once again, thank you for your contribution

mangalaman93 avatar Feb 21 '23 07:02 mangalaman93