Mandric Mihai
Mandric Mihai
@josegonzalez I added unit tests
Looks like some code style fails. I will fix it later today.
@josegonzalez could you review, please?
I think you are right.In this case, we can close the pull.
@josegonzalez before getting the doc for this, we should decide what to do with the type and the size, right now they are not supported and if we are ok...
The problem is not how to determine the file size and type, is where do we put that code that does this?
That will solve one problem. How about this `if` https://github.com/FriendsOfCake/cakephp-upload/pull/495/files#diff-84c66ea1e7013949dabde1157612da57R103 Are you ok with having this `if` or is better to make another interface?
@josegonzalez Sure, I will add the docs this week.
I don't think it should be in validation.We want to use the methods to get the actual size and file type https://github.com/FriendsOfCake/cakephp-upload/pull/495/files#diff-84c66ea1e7013949dabde1157612da57R123 so that we can set on the entity.
We can provided a method in ImageValidationTrait.php that uses https://secure.php.net/manual/en/function.imagecreatefromstring.php