Kyle Mandli

Results 340 comments of Kyle Mandli

We should brain storm a way to have an example we can share and a test to make sure it works. Something synthetic would work.

Exactly what I was thinking.

@cjeffr Do you want to chat about this? I just looked through to remind myself what changed but I have some easy suggestions that may be good to do.

This looks good to me save for a warning that is popping up in the tests: ``` testdiscontinuous is used to test discontinuous function with `integral_topotool`. ... /home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/scipy/integrate/quadpack.py:860: IntegrationWarning: The...

Can you also change `patch` to be a dictionary being passed through the chain rather than an object?

Thanks @RunxinNi. @rjleveque does this look good to you now?

Just realized that this PR is still in the waiting. @rjleveque have you had a chance to look at this again?

@rjleveque has volunteered to create a PR for this.

Can you provide more of the output? There's nothing that should cause that to occur off-hand.