geoclaw icon indicating copy to clipboard operation
geoclaw copied to clipboard

Published 20 hours ago • verified publisher icon clawpack

Owi integration

Open cjeffr opened this issue 3 years ago • 10 comments

This PR is to add functionality to use data storm products such as Oceanweather (OWI) wind and pressure files for storm simulations. Example case will be sent separately as the current example is using proprietary data that can't be shared publicly.

cjeffr avatar Jan 10 '22 22:01 cjeffr

@cjeffr could you remove the extra files that only have a whitespace changes? While I generally am fine with removing whitespace it looks like a bunch of files have been touched that are not related to the PR.

mandli avatar Jan 11 '22 19:01 mandli

Yeah that was weird, I have fixed it.

cjeffr avatar Jan 11 '22 19:01 cjeffr

@cjeffr is there a way we can a test or example for this added along side of this PR?

mandli avatar Feb 07 '22 22:02 mandli

The only example I have is one provided by the corps, if you have another data driven example I can modify it to make it work like OWI so that many people can use it.

cjeffr avatar Feb 07 '22 22:02 cjeffr

We should brain storm a way to have an example we can share and a test to make sure it works. Something synthetic would work.

mandli avatar Feb 07 '22 22:02 mandli

One thing that immediately comes to mind is to just build a wind and pressure field using a hurdat or atcf example and the actual math like in geoclaw's original storm functionality but then save the data into the same format as the OWI netcdf file I created. Should be a reasonable approximation and can be tested against the original?

cjeffr avatar Feb 07 '22 22:02 cjeffr

Exactly what I was thinking.

mandli avatar Feb 07 '22 22:02 mandli

Ok I'll get started on that

cjeffr avatar Feb 07 '22 22:02 cjeffr

@cjeffr Do you want to chat about this? I just looked through to remind myself what changed but I have some easy suggestions that may be good to do.

mandli avatar Nov 10 '23 15:11 mandli

Yes please I have made some changes since this pull request that I am planning to add soon and I have a few questions for the read and write routines to go into storm.py.

From: Kyle Mandli @.> Sent: Friday, November 10, 2023 10:59:57 AM To: clawpack/geoclaw @.> Cc: Jeffries, Catherine @.>; Mention @.> Subject: Re: [clawpack/geoclaw] Owi integration (PR #531)

@cjeffrhttps://github.com/cjeffr Do you want to chat about this? I just looked through to remind myself what changed but I have some easy suggestions that may be good to do.

— Reply to this email directly, view it on GitHubhttps://github.com/clawpack/geoclaw/pull/531#issuecomment-1806001555, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFM5WPFMF2OZNMN2IN6N6QTYDZFP3AVCNFSM5LU3DYU2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBQGYYDAMJVGU2Q. You are receiving this because you were mentioned.Message ID: @.***>

cjeffr avatar Nov 10 '23 16:11 cjeffr