Katerina Skroumpelou comments

Results 130 comments of


                                            Katerina Skroumpelou

@nrwl/react adds dependencies to root package.json instead of library when generating publishable library

Can you please retry with latest?

@nrwl/react adds dependencies to root package.json instead of library when generating publishable library

@ndcunningham adding you to this conversation!

feat(bundling): added support for declarations (*.d.ts)

Tested this locally, and the tests on CI seem to pass, so I am going to merge. However, once `esbuild` is part of the crystal project, this functionality will go...

chore(core): nx plugin submission nx-clone

@isaacplmann I assigned you because it's "plugin submission request", although it seems that the plugin does not have e2e tests, which we require? @AndrewRedican did you get a chance to...

feat(vite): include env files in sharedGlobals for vite projects

Hi there @gerarts ! Thank you for this PR! We have changed a lot since you first submitted it, so could you please change your implementation a bit? Can you...

vitest CLI (and other vitest tools) do not work properly for monorepos

Yes, we will work on it in January

vitest CLI (and other vitest tools) do not work properly for monorepos

This should already work in Nx if you add a `vitest.workspace.ts` file at the root of your Nx workspace, as described here: https://github.com/nrwl/nx/issues/18204#issuecomment-1652003698 by @barbados-clemens Here's a repository you can...

Bug: Does not work in esm projects

Hi there @kasperpeulen ! Thank you for the enhancement request, and thank you for your patience too. Do you have a suggested implementation for this? Would you like to submit...

Orb using with other orbs

Hi there @gerd-siebert ! Thanks for creating this feature request! Do you have any suggested implementations? Would you like to submit a PR? And I can help you, and review...

feat: add allow not run workflow option

Hello @eladhaim ! Thank you for your contribution! I will make sure to take a look next week and see if it makes sense for us to merge this! Thank...