nx-orb icon indicating copy to clipboard operation
nx-orb copied to clipboard

feat: add allow not run workflow option

Open eladhaim opened this issue 2 years ago • 5 comments

SEMVER Update Type:

  • [ ] Major
  • [x] Minor
  • [ ] Patch

Description:

Motivation:

Closes Issues:

Checklist:

  • [x] All new jobs, commands, executors, parameters have descriptions.
  • [x] Usage Example version numbers have been updated.
  • [x] Changelog has been updated.

eladhaim avatar Jan 21 '24 21:01 eladhaim

@meeroslav can you take a look of this?

eladhaim avatar Jan 24 '24 14:01 eladhaim

Would really nice to have it!! Great contribution!

uribrod avatar Feb 21 '24 18:02 uribrod

Hello @eladhaim ! Thank you for your contribution! I will make sure to take a look next week and see if it makes sense for us to merge this! Thank you for your patience and understanding!

mandarini avatar Jun 11 '24 12:06 mandarini

Hi @uribrod, the purpose of this orb is to guarantee no failure goes under the radar by ensuring to always run nx affected against the last successful run.

Both on-hold and not-run are not guaranteed to be successful so that would work against the fundamental requirement of this orb.

I don't think the feature proposal makes sense.

meeroslav avatar Sep 04 '24 07:09 meeroslav

so i will explain our needs, we are pushing some packages from our monorepo and updating our github repository in this process, adding tags and commits. Those commits has [skip ci] in the title to avoid cci to fire a build, but it' still get created in cci as a workflow with not_run status which get included in the calculation of the last workflow success .

eladhaim avatar Sep 04 '24 08:09 eladhaim