Katerina Skroumpelou comments

Results 166 comments of


                                            Katerina Skroumpelou

return type of `getAuthorizationDetails` is wrong

Fixed here: https://github.com/supabase/supabase-js/pull/2088

fix(storage): add no-store cache control to download

related - https://github.com/supabase/supabase/issues/41841 - https://github.com/supabase/supabase/pull/41855 Thanks for the PR @Akkii88 . I am not sure I will approve, need to discuss/think about it. In the meantime, can you please remove...

fix(storage): add no-store cache control to download

Hi @Akkii88! Thank you for identifying this issue and proposing a fix. The problem you've identified is real, `download()` doesn't provide a way to control caching, which causes stale data...

fix(realtime): add generic overload for postgres_changes event type

@7ttp thank you for this PR. Can you please add a test for the new functionality? It can go in `packages/core/realtime-js/test/RealtimeChannel.postgres.test.ts`. Something like: ```ts ... const event: '*' | 'INSERT'...

fix(realtime): add generic overload for postgres_changes event type

@7ttp can you please rebase your PR with latest `master`? We made some updates in the workflows, and it will be blocked if you don't rebase

fix(storage): expose status and statusCode on StorageError base class

@7ttp can you please rebase your PR with latest `master` to fix the failing pipeline?

build(deps): bump tar and supabase

@dependabot rebase

fix(auth): add dispose method to cleanup BroadcastChannel

Hi @7ttp ! Thank you for the PR! I discussed it with the auth team and we decided that we will not be merging this PR. We do not see...

fix(auth): correct getAuthorizationDetails return type for already consented OAuth responses

Thank you for identifying and fixing this issue! The type mismatch you've found is indeed a real bug, the current types don't match the actual API behavior. However, I'd like...

fix(auth): correct getAuthorizationDetails return type for already consented OAuth responses

Hey @7ttp! Unfortunately, I think I'm going to close this PR in favor of a more comprehensive fix. The problem is on us. The issue with this PR: While you...