Joshua Hellier
Joshua Hellier
It is densely coupled to everything else in framework.py and this makes refactoring that file basically impossible; please destroy.
framework.py has 4.2k lines; it'll be much easier to refactor the class structure and improve documentation if it's split up into smaller parts.
## Describe your changes `DataOrder` densely coupled to other entities in `framework.py` (in particular `DataContainer` which we seek to isolate in the grander scheme of this hackathon's refactoring). To alleviate...
## Description A callback which lets us evaluate user-defined functions on an `Algorithm` and save solution state under user-defined conditions. Evaluations of functions and locations of saved solution artifacts are...
## Description Currently, `Algorithm` has the method `get_last_loss`. This is fine for algorithms which have a single relevant component to their loss, but leads to unexpected behaviour when used with...
## Description Issue I came across trying to make callbacks which can store calculation state. Best situation would be that `DataContainer` would have a (possibly abstract) save method which would...
## Description Updated the docstring for PDHG to hopefully make it a bit clearer. Feel free to change. Related issue is https://github.com/TomographicImaging/CIL/issues/2219 . ## Contribution Notes - [ x] The...
## Description While using PDHG for the first time in a while, kept having problems getting it to run until I examined PDHG's docs very thoroughly. Would be nice if...