Malte Lenz

Validity of clocked signals in reference results

6

Reading a reference result with variables that are clocked, [like this](https://github.com/modelica/MAP-LIB_ReferenceResults/blob/v4.0.0/Modelica/Clocked/Examples/Elementary/BooleanSignals/BackSample/BackSample.csv), what part of that file can or should be trusted/used for correctness checking? A: All points B: Only the...

What does an empty annotation mean, if anything?

12

There seem to be interpretations that adding an empty annotation like `annotation(Dialog)` means something different than having no annotation at all, see https://github.com/modelica/ModelicaStandardLibrary/issues/3726#issuecomment-762823785 and the discussion following it. If this...

What do the expressions in choice mean?

5

Consider these classes: ``` package C constant Real p = 1.0; model B parameter Real ch annotation(choices(choice = p)); end B; model TestModel constant Real p = 2.0; B b;...

Illegal call to zeros with negative argument

2

The call to `zeros(n_q - 1)` here: https://github.com/modelica-3rdparty/PowerSystems/blob/69fd1e7381fb50e6a0bc77d9ba168e9d6a7d9a6a/PowerSystems/Examples/AC3ph/Precalculation.mo#L1142 seems to come down to `zeros(-1)`, if we resolve `n_q`: https://github.com/modelica-3rdparty/PowerSystems/blob/69fd1e7381fb50e6a0bc77d9ba168e9d6a7d9a6a/PowerSystems/Examples/AC3ph/Precalculation.mo#L1137 https://github.com/modelica-3rdparty/PowerSystems/blob/69fd1e7381fb50e6a0bc77d9ba168e9d6a7d9a6a/PowerSystems/Examples/AC3ph/Precalculation.mo#L1116 giving the expression `zeros(size(fill(0, 0), 1) - 1)` ==> `zeros(-1)`,...

Lookup in partial class

1

This: https://github.com/RWTH-EBC/AixLib/blob/feb8ebf64bfd64931e3ff0c15ddce73c4d10f9da/AixLib/DataBase/CHP/ModularCHPEngineMedia/NaturalGasMixture_TypeAachen.mo#L31 does a lookup in a partial class `Modelica.Media.Interfaces.PartialMixtureMedium`, which is not valid Modelica.

The casing of the file name here: https://github.com/RWTH-EBC/AixLib/blob/feb8ebf64bfd64931e3ff0c15ddce73c4d10f9da/AixLib/package.mo#L145 doesn't match the casing of the actual file: https://github.com/RWTH-EBC/AixLib/blob/development/AixLib/Resources/Images/Icon_Modelica_AixLib.png Note the lower/uppercase `L` in `AixLib`. This means the logo will not show...

These lines use `` on Reals, which is only allowed inside functions: https://github.com/RWTH-EBC/AixLib/blob/f2c600fe7a145916dbb7326a35cf7f96a7edd0aa/AixLib/DataBase/Pumps/PumpPolynomialBased/Examples/testMaxMinHeightTable.mo#L29 https://github.com/RWTH-EBC/AixLib/blob/f2c600fe7a145916dbb7326a35cf7f96a7edd0aa/AixLib/DataBase/Pumps/PumpPolynomialBased/Examples/testPumpPowerCalculation.mo#L51 https://github.com/RWTH-EBC/AixLib/blob/f2c600fe7a145916dbb7326a35cf7f96a7edd0aa/AixLib/DataBase/Pumps/PumpPolynomialBased/Examples/testPumpHeadCalculation.mo#L54 https://github.com/RWTH-EBC/AixLib/blob/f2c600fe7a145916dbb7326a35cf7f96a7edd0aa/AixLib/DataBase/Pumps/PumpPolynomialBased/Examples/testPumpHeadCalculation.mo#L61 https://github.com/RWTH-EBC/AixLib/blob/f2c600fe7a145916dbb7326a35cf7f96a7edd0aa/AixLib/DataBase/Pumps/PumpPolynomialBased/Examples/testPumpSpeedCalculation.mo#L63

Here: https://github.com/mtiller/ModelicaBook/blob/a8677a650f4d84322914e18b06b26c8f1e7c387f/ModelicaByExample/Functions/Polynomials/EvaluationTest1.mo#L4-L7 The equation `yp = time^2-2*time+2` is questionable from a unit perspective, since it subtracts things with units `s2` and `s`, which are not compatible units. The same issue...

MSL 4.1.0 Reference results for new models

9

MSL 4.1.0 comes with new example models compared to 4.0.0. These need new reference results at https://github.com/modelica/MAP-LIB_ReferenceResults/tree/v4.1.0 List of new models: ``` Modelica.Blocks.Examples.DemonstrateContinuousSignalExtrema Modelica.Blocks.Examples.DemonstrateSignalExtrema Modelica.Blocks.Examples.DemoSignalCharacteristic Modelica.Electrical.Analog.Examples.DemonstrateLightning Modelica.Electrical.Analog.Examples.DemoPowerSupply Modelica.Electrical.Analog.Examples.DemoPowerSupplyWithBuffer Modelica.Electrical.Analog.Examples.Lines.CompareLineTrunks Modelica.Electrical.Analog.Examples.Lines.CompareLosslessLines...

Remove binaries from repository

1

Binaries should be built separately, as discussed in #4250.