Malte Kliemann
Malte Kliemann
If the oracle fails to report and another user steps up to the plate, should they stake ZTG? I think so. Although we don't want to discourage people from reporting...
The following tests result in unexpected results: ```rust #[test] fn join_subsidy_after_collection_fails() { ExtBuilder::default().build().execute_with(|| { assert_ok!(Swaps::create_pool( BOB, ASSETS.iter().cloned().collect(), ASSETS.last().unwrap().clone(), 0, ScoringRule::RikiddoSigmoidFeeMarketEma, None, None, None, )); let who = ALICE; let pool_id...
This status is unused and should be removed completely.
See https://github.com/zeitgeistpm/zeitgeist/pull/687 for details. We need to ensure that a PR can only be merged under the following conditions: - It has been approved by review - The CI was...
There are a lot of optional parameters required for creating Balancer-style pools. From a design point of view, this is a code smell. Either `weights` and `swap_fee` must _both_ be...
It is possible to destroy a market in `Disputed` state using `admin_destroy_market`, but this will not result in the dispute bonds being released. This is a bug, but it would...
A quick skim of the code reveals that an advised Rikiddo market can be approved one minute before it will end. On the contrary, creating a permissionless Rikiddo market with...
Currently, `admin_move_market_to_closed` does not properly handle subsidies when moving an active market to closed.
Currently, `deploy_swap_pool_for_market` verifies that there isn't a pool associated with the market already. I believe that this check belongs in the `market-commons` module instead.