Malte Kliemann

Results 92 comments of Malte Kliemann

We resolved to not use negative numbers.

We can see that the script works, since it shows us that the `pallet-collective` benchmarks fail. Let's merge the fix for that, and then we can do the review here.

This is somewhat related to #742. On the chain side, we can fix this by adding a short message in an event, similar to how `System::remark()` works. But to facilitate...

I like the `EditReason` you built into #834. That allows us to have a track record on the blockchain. But I think there should also be a front-end solution.

Just a dumb question: The report says 92.37% coverage. What exactly does that number mean? There seem to be two different workflows running, one for unit tests and one for...

What's the blocker here? Also, can we get a notification when one of our PRs needs to resolve a merge conflict? https://docs.mergify.com/actions/comment/#request-for-action

Yeah, good to have an issue for this. We're already planning a new AMM design which will mitigate this problem.

By size you mean "How much work is it going to take to fix it?" or "How bad is it?"? We use priorities for the latter. I'd like to start...

~~Closing because I want to clean up the history.~~ Nevermind, too much work.