zeitgeist icon indicating copy to clipboard operation
zeitgeist copied to clipboard

Published 20 hours ago • verified publisher icon zeitgeistpm

Update CI to quick check benchmarks

Open Chralt98 opened this issue 2 years ago • 2 comments

Fixes partially https://github.com/zeitgeistpm/zeitgeist/issues/822

Chralt98 avatar Oct 06 '22 10:10 Chralt98

To make a script executable this command was required.

git update-index --chmod=+x ./scripts/benchmark/quick_check.sh

Chralt98 avatar Oct 06 '22 10:10 Chralt98

We can see that the script works, since it shows us that the pallet-collective benchmarks fail. Let's merge the fix for that, and then we can do the review here.

maltekliemann avatar Oct 06 '22 11:10 maltekliemann

As soon as this PR is merged, #822 can be closed, as you pointed out. 👍 I will wait for the second review and your release in Discord.

Chralt98 avatar Oct 18 '22 06:10 Chralt98

Please respect point 2. at https://github.com/zeitgeistpm/zeitgeist/pull/841#issue-1416377613 before merging this.

sea212 avatar Oct 20 '22 10:10 sea212