Matt Liberty
Matt Liberty
> I've heard this API is planned to raise exceptions internally? > > At Google exceptions are really hard to work with, would it be possible pipe them out somehow?...
This is a python API so are you objecting to python exceptions or c++ ones? The c++ exceptions would be converted to python ones by swig. Or are you planning...
> oh sorry, just the C++. > > I indeed do not boost or stl, I use absl There is no chance that we will convert away from those. I...
https://github.com/abseil/abseil-cpp/blob/1ae9b71c474628d60eb251a3f62967fe64151bb2/absl/base/internal/throw_delegate.cc#L109 is pretty icky - it just calls std::abort rather than throw which allows no handling at all (if ABSL_HAVE_EXCEPTIONS is off).
> > Do you wrap everything you use? > > Yes. Any exception generating third_party lib that Google pulls in has to be wrapped before it can be used outside...
Yes. I've started an implementation but keep getting side tracked. There is some complications with the app level callbacks that I think need to be moved into odb callbacks instead.
@QuantamHD I'll clean it up later today and do that.
@proppy I closed #1659 but I think #1424 should be kept for the pip work which is separate.
> @QuantamHD I'll clean it up later today and do that. https://github.com/The-OpenROAD-Project/OpenROAD/pull/1849 which should be viewed as just where I am today.
Why would you want PDN to be fixed if the core area is moving underneath it? You may wind up with a poor grid that doesn't cover the core area.