Matt Liberty

Results 1713 comments of Matt Liberty

Looking at ng45/gcd I see that the message is in 3_1_place_gp_skip_io.log. We shouldn't warn about unplaced pins when skipping io as we are ignoring them.

aes on what pdk? Are the slacks negative or positive?

@QuantamHD please assign a Google reviewer

I'll review after your comments are addressed

If you don't include if.h in ac_wrapper.h, what are "those functions" that it complains about?

Looks similar to [#8737](https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/issues/3584)

It seems that having some document or global options on fast analysis is better than sprinkling hints throughout the log

@precisionmoon does this represent something of concern? It sounds like the message needs more information (or to be removed)

If you look at test_inst.tcl you'll see they avoid the logger issue by using `createSimpleDB 1` to use the default db that already has a logger. I prefer to not...

Since pr-merge is passing I'm not worried about pr-head.