Craig Brookes

Results 14 comments of Craig Brookes

@odra there is an on going discussion here https://github.com/openshift/ansible-service-broker/issues/859 on the topic

One of the uses here is to essentially provide useful metadata for other consuming clients. For example a CLI or a UI. Being able to add labels means that the...

issue created here back in September by myself (lol) updated with more details https://github.com/kubernetes-incubator/service-catalog/issues/1222

@dymurray there is a proposal in progress for the service catalog to allow labels and annotations to be specified in the metadata for the cluster service class. If you look...

+1 agree completely. Currently the broker crashes (at least the version I have) if any of the yaml is not valid

@deads2k sure I will take a look at doing that. I have added something similar here https://github.com/openshift/open-service-broker-sdk/pull/29/files I will base the PR for this repo from that work

@deads2k Looking for some guidance. Fairly new to Kubernetes apiservers. In this repo the clientsets are not generated yet, should the generated clientsets be part of the sample-apiserver? In your...

@p0lyn0mial ok thanks, I had looked at those, having trouble with the update-codegen as it seems to want to be run from the root of kubernetes. Hoping to give this...

We use the following for this in our makefile. Happy to make a PR ``` check-gofmt: diff

I am also seeing this behaviour on node v0.10.4. If i call gc() without the --expose-gc flag the stats listener isn't called but works fine when the flag is added