Malcolm Rowe

clang-format version detection is slightly broken (and definitely so for trunk builds)

2

At https://github.com/google/vim-codefmt/blob/293c208/autoload/codefmt/clangformat.vim#L32-34, we have this code: ```viml let l:version_string = matchstr(l:version_output, '\v\d+(.\d+)+') " If no version string was matched, cached version will be an empty list. let s:clang_format_version = map(split(l:version_string,...

codefmt shouldn't call FormatRanges with empty a:ranges

1

As noted in #48, we seem to have some cases where a formatter's `FormatRanges()` will be invoked with an empty `a:ranges`. Either that, or we're unnecessarily checking for emptiness in...

gofmt formatter doesn't clear quickfix list when all errors are fixed

3

(Forwarding a report from someone else) I am using the codefmt plugin for Go, by including: ``` vim Glug codefmt gofmt_executable="goimports" Glug codefmt-google autocmd FileType go AutoFormatBuffer gofmt ``` And...

Consider providing a standard way for formatters to report errors

1

Currently, if formatters want to report errors, they update the quickfix list directly. (As shipped, only the gofmt formatter does this, but it would also make sense for e.g. google-java-format,...

Be more tolerant about plugin name conflicts

8

Adding two plugins with the same canonical name to `&rtp` breaks Maktaba's plugin detection completely, reporting e.g. ``` Error detected while processing function maktaba#plugin#Detect[2]..maktaba#plugin#GetOrInstall: line 11: E605: Exception not caught:...

Maktaba should offer a simple log handler

4

Maktaba's logging is useful, but unless I'm missing something, there's easy no way to use it out of the box, as you need your own log handler before it'll do...

Odd behaviour with :silent! call maktaba#plugin#Detect()

2

This may not really be a Maktaba problem at all, but it's odd nonetheless. Given the following `.vimrc`, and Vim 7.4.922: ``` viml set nocompatible set rtp=foo,foo.vim,bar source maktaba/bootstrap.vim ```...