Malcolm O'Hare

Results 14 comments of Malcolm O'Hare

I'm also waiting for this to be fixed. I think if this plugin is fundamentally broken because the lack of this parameter, we should ship the breaking change. It's a...

I'd prefer this PR being merged. My submission was just to offer an alternative if there was too much pushback to making the breaking change.

Confirmed this impl of the plugin works and returns the original behavior of the Resolver Codegen ``` func (m *Plugin) Implement(prevImplementation string, field *codegen.Field) string { if prevImplementation != ""...

Is there a way to provide an ENV for the CodeLens to include in the test invocation? Then you could gate the simplecov config with something like `ENV['SIMPLECOV_DISABLED'] == true`....

Fully backwards compatible, just need to fix 3.2 and up. The behavior of ruby2_keywords changed between 3.1 and 3.2: https://rubyreferences.github.io/rubychanges/3.2.html#keyword-argument-separation-leftovers

The main plugin has an open issue for this: https://github.com/Shopify/ruby-lsp/issues/2402 The test execution loop in the extension [is here](https://github.com/Shopify/ruby-lsp/blob/main/vscode/src/testController.ts#L256). It will execute anything marked with the 'example' tag. But it...

investigating CLA status

I have signed the CLA!

Perhaps there are multiple issues then? My specific issue was that the lockfile you are generating in the lsp directory is getting different dependency versions that my application lock file....

I see the same, but opposite, issue. The RubyLsp generated lockfile does not obey the contents of my projects own lockfile. For at least the immediately problematic gem, it selected...