Malcolm Kee

Results 24 comments of Malcolm Kee

Sharing a recent setup in my current company that is **NOT** monorepo (can't share code as it's not open-sourced, but happy to clarify!). The key components are: 1. npm org...

This seems like due to build optimization. In source code there is a undefined check: https://github.com/Andarist/react-textarea-autosize/blob/0d7ac21f1dadf1fb9070aea5f76f20b7ce2f24bc/src/getSizingData.ts#L43 But in actual packaged code, the check is gone ```js // react-textarea-autosize.browser.esm.js // line...

@Andarist I supposed too! But not sure if it's the same for @OlehRb

@OlehRb check if rollup bundle this package. If yes, you can use the `external` options: https://rollupjs.org/guide/en/#external

Right now I think the style improvement is not substantial. I'll add examples that use `ts-loader` as that print out some code snippet and iterate more. Created this MR in...

I find out that `react-error-overlay` has extra logic to open file with error if the filename and line of code can be detected using [this middleware](https://github.com/facebook/create-react-app/blob/main/packages/react-dev-utils/errorOverlayMiddleware.js). Should I add this...

There is a workaround in the meantime, by "abusing" framecomponent to append scripts/stylesheet in the head. Example: ```tsx import * as React from 'react'; function useStylesheet(url: string) { React.useEffect(() =>...

I think all the 3 listed can be implemented independently. I would like to share my current thought on number 3 (improve styles). Based on what I've seen in `react-error-overlay`,...

CRA error stack was pretty nice as it showed code snippet, but I not sure if that's possible given that we don't have control over `devtool` options. Other than that...

> Can you show me, because we can use generate source maps (if they were enabled) Found the following gif from [here](https://blog.jakoblind.no/error-overlay-with-react-hot-loader/). ![cra-runtime-error](https://user-images.githubusercontent.com/24528512/236681895-04dbb091-3a0e-4673-8c15-6775ae64a21b.gif)