Sergei Malafeev

Results 33 comments of Sergei Malafeev

@redzippo1 sounds cool

yes, one issue is that #poll and #commit are executed in different threads, another that #poll returns several messages and for each message new consumer span is created because each...

@Xitric SpecialAgent is not actively supported anymore. I would suggest to look at OpenTelemetry, specifically to https://github.com/open-telemetry/opentelemetry-java-instrumentation

no, I don't have any vendor-free recommendation. you can probably create manual opentracing instrumentation for your application using existing opentracing libraries (https://github.com/opentracing-contrib).

looks like only servlet api is traced

@mayanksriv java-akka doesn't have any serializer for DistributedMessage. Therefore you need to configure it. In PR #380 I made `io.opentracing.contrib.specialagent.rule.akka.actor.TracedMessage` to contain only 2 fields: original message and map. It...

I think we can remove `spring-web-*` rules because it's covered by `HttpUrlConnection` and `thread/concurrent` rules. `spring-web-*` uses `HttpUrlConnection` to send requests.

yes, it looks like TracingSubscriber.onComplete() is never called, therefore span is not finished: https://github.com/opentracing-contrib/java-spring-web/blob/master/opentracing-spring-web/src/main/java/io/opentracing/contrib/spring/web/webfilter/TracingSubscriber.java#L77

If I use in my app tomcat then I see that `TracingSubscriber.onComplete()` is called. But if I don't use tomcat and rely on netty which comes with spring-webflux I don't...

@geoand it would be great if you take a look even in a while. Currently I don't have enough time.