Matti Kortelainen

Results 415 comments of Matti Kortelainen

We should probably revive doing these updates, but in smaller chunks (maybe even one at a time) to be able to conclude.

I was thinking to address these myself, but wanted to open an issue in the mean time.

Do the Core Guidelines say anything about either?

I know and agree, I was just wondering if the Core Guidelines would have a recommendation we could refer to (sorry I was unclear).

> i also notice that our ban on `cout` is not described in the code rules, this should definitely be added It sort-of falls under 7.2 ("Ensure code is thread-safe"),...

> Is it written somewhere about avoiding `using namespace` in header files? It is not part of our current code rules (although our tools flag it), which is why I'm...

Maybe we should add something about `thread_local` as well.

> what about (currently 4.7) `Do not forward-declare an entity from another package.` ? > It seems to be systematically violated. > Should some note like `not really enforced and...