Matti Kortelainen

Results 415 comments of Matti Kortelainen

FYI @cms-sw/hlt-l2 @cms-sw/egamma-pog-l2

@cmsbuild, please test for el9_amd64_gcc11

@Dr15Jones @wddgit Can you think of any ill side effects that might not be covered by our unit tests?

Thanks @wddgit. I would think we could either restrict `callWhenNewProductsRegistered()` callback to be called only for branches that are present, or go through all `callWhenNewProductsRegistered()` callbacks and add a check...

I tested that currently indeed `callWhenNewProductsRegistered()` callbacks are called for non-present branches as well. I went through all uses of `callWhenNewProductsRegistered()`, here are notes from that ### `L3TkMuonProducer` https://github.com/cms-sw/cmssw/blob/1a59ba00193440d65339de1c600e01c15993e5de/RecoMuon/L3MuonProducer/src/L3TkMuonProducer.cc#L36-L42 AFAICT...

> The `ThinningProducer` looks potentially more fundamental problem, need to think about it more. After some more thought and poking around the code, I think now that the `ThinningProducer` is...

I added a protection for dropped branches in `ThinningProducers` in the last push. The `callWhenNewProductsRegistered()` are handled in #38872.