Ben Abrams
Ben Abrams
We could change this logic to loop over them and append them to an array or hash and then make a check after evaluating each of them which is a...
Would you be willing to attempt a pr for this?
I am all for the first part I need to look through the code and think about how I feel about combining the params. Could we simply start with the...
Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.
Overall looks like a great improvement. I took a look at the CI failures, I will work on getting those clean this weekend.
So the CI failure is caused by https://github.com/ruby/net-telnet/issues/14 where `0.2.0` dropped ruby < 2.3 support. We can pin it for now but I plan on releasing a major shortly after...
So the problem now was that `net-ssh` requires at least ruby 2.2: ``` Fetching: net-ssh-5.0.2.gem (100%) /usr/local/lib/ruby/site_ruby/2.1.0/rubygems/installer.rb:611:in `ensure_required_ruby_version_met': net-ssh requires Ruby version >= 2.2.6. (Gem::InstallError) ``` Honestly at this point...
I assume this is self signed?
@Rizbe does that help?
> I think that [source_branch](https://www.terraform.io/docs/providers/github/r/branch.html#source_branch) argument should default to `main` Perhaps we should remove the default or make it look that up (if not specified) since that is a per...