Ben Abrams comments

Results 584 comments of


                                            Ben Abrams

check-es-cluster-health warning ::Fixnum

I checked and we can bump to 2.x when I have some time I can try bumping this I am more concerned about the lack of testing in this plugin...

[metrics-es-node-graphite] jvm_stats max_heap_size_in_bytes already done by Elasticsearch

@chrisduong sounds like something we want, do you have a pr for review?

New check for number of shards for the whole cluster

In https://github.com/elastic/elasticsearch/pull/34021 they merged and will be something that affects 6.5 as a warning and will be prevented in 7.0 without a log message making this very important.

Add tests

I would say that ES has EOL 1.x so we should drop support on it and we should focus on 2.x and 5.x: https://github.com/sensu-plugins/sensu-plugins-elasticsearch/issues/48#issuecomment-299776709

Add tests

oops accidental close...

ES2.x Query DSL is not used in the /bin/check-es-query-count.rb script

@agastya71 could you put togethor a pr with the proposed changes and we can further discuss there?

metrics-disk-capacity doesn't parse LVM volumes correctly

@madAndroid can you please put together a pr for this?

Docker warning

related: https://github.com/sensu-plugins/sensu-plugins-disk-checks/issues/53

Docker warning

@ulrith is there anything else we need to do here? I am thinking we should add some documentation as multiple users have reported. Would you be willing to put together...

Docker warning

You can try using this: https://github.com/sensu-plugins/sensu-plugins-disk-checks/issues/52#issuecomment-240625827 to not check that.