Results 584 comments of Ben Abrams

So that works but I think that it would be better to fix the defaults to not be a string in the first place. We see in multiple locations we...

So it is I actually opened that document and somehow skipped right over it. I am glad we do as I was very confused as I recalled seeing something. Great...

Could you please include your full (redacted) check configuration from the screenshot I am not sure which metrics script to look in.

OK I think I see the confusion you are executing this as a [check](https://sensuapp.org/docs/1.1/reference/checks.html) when this is actually in fact a [handler](https://sensuapp.org/docs/1.1/reference/handlers.html). As this does not match the naming convention...

Over [here](https://github.com/sensu-plugins/sensu-plugins-mysql#troubleshooting) it states the need to install `libmysql-client-dev` have you installed it?

> The codeclimate-test-reporter in the (existing) test/spec_helper.rb prevents the tests from running. Can I ditch it? ya we kinda abandoned that as we had pretty low unit test coverage and...

Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.

I will review the code in a minute but I did want to point out that sensu natively has its own flap detection algorithm borrowed from nagios. The Documentation is...

I am having a hard time coming up with a good name as its pretty much trying to work around a reporting bug. Maybe something like `--discard-invalid-results-threshold`, `--discard-invalid-results-retries`, `--discard-invalid-results-sleep`? I...