Miguel Duarte Barroso

Results 250 comments of Miguel Duarte Barroso

/test pull-kubevirt-e2e-k8s-1.22-sig-network

/test pull-kubevirt-e2e-k8s-1.23-sig-storage /test pull-kubevirt-e2e-k8s-1.24-sig-storage-dv-gc

/test pull-kubevirt-e2e-kind-1.22-sriov

/test pull-kubevirt-e2e-kind-1.22-sriov

> > I think it is preferable to invoke `mockDomain.EXPECT().Free()` in a [defer cleanup](https://onsi.github.io/ginkgo/#cleaning-up-our-cleanup-code-defercleanup) - a ginkgov2 construct, since it would require less test changes. > > Hi @maiqueb ....

I think this would be a very valuable contribution. However, I'm concerned about a couple of things: - we would need you to be willing to actively maintain this code...

Some more questions: - for which binding type would this apply to ? bridge ?... - did you consider IPAM (when bridge binding is used) in this scenario ? Like,...

Would you consider making this a draft PR to prevent CI from being overloaded ? I am being spammed with failing test lanes from this PR. @kvaps ^

[`make functests`](https://github.com/kubevirt/kubevirt/blob/main/Makefile#L76) ? You need a running cluster. If it is provided by kubevirtci, you don't need to do anything else. You can also pass it localized options to indicate...

> > would you re-phrase your commit msg ? > > The part I'm copying below is confusing. > > > The reason is that the tap device which is...