Magnus Nord

Results 135 comments of Magnus Nord

Some of the tests are also failing due to changes in the peak finding, for example `blob_dog`. Not sure exactly why, I'll have a look at it. Some of tests...

With regards to `blob_dog`, it seems to be related to the `sigma_ratio` parameter. Not sure if it is a bug fix in `skimage` or a regression. --------- To test this:...

The `blob_dog` changes are due to this pull request in `scikit-image`: https://github.com/scikit-image/scikit-image/pull/5503 I'll update the pyxem functions to take this into account.

> The blob_dog changes are due to this pull request in scikit-image: https://github.com/scikit-image/scikit-image/pull/5503 > > I'll update the pyxem functions to take this into account. Fixed in https://github.com/pyxem/pyxem/pull/798

Indeed! If you're able to keep all the processing using `dask`, and within each chunk, you can do some very, very memory and time efficient processing. It takes a little...

> Thanks for this. I think one of the main problems we had with testing the .mib reader was getting small enough working file examples. One trick with testing MIB-files,...

I have a TEM session with our single chip MerlinEM camera on Friday, if you need some .mib files.

Unfortunately, I didn't have the time to acquire the test datasets at that session. However, I'm on the TEM (fairly) regularly, using the Merlin, so I'll be able to grab...

In non-COVID times I could easily have gotten some nice datasets for this. At the moment I'm mostly doing home office... With regards to optimal datasets, I'm guessing the best...

I acquired some MIB-files with some different settings: [merlin_mib_files_for_unit_tests.zip](https://github.com/pyxem/pyxem/files/6451340/merlin_mib_files_for_unit_tests.zip) - 4 x 2 probe position - Probe on detector - 24, 12, 6 and 1 bit - Not using region...