Magnus Nord

Results 135 comments of Magnus Nord

Doesn't the `dask_tools._process_dask_array` already do this? Example: ```python import hyperspy.api as hs from scipy.ndimage import gaussian_filter from pyxem.utils.dask_tools import _process_dask_array s = hs.load("test_data.hspy", lazy=True) # 4-dimensional dataset data_gaussian = _process_dask_array(s.data,...

With regards to `_process_dask_array`, it is currently implemented in a fairly "general" way. So that any function which processes a single 2D image can be used. However, there are probably...

> Shall we use this thread as a place to keep track of such duplications? Sounds good! Some other functions are `radial_integration` and `radial_average`. I'm tempted to wait until https://github.com/pyxem/pyxem/issues/759...

> Using the COM to center the direct beam is possible but was curious as to the situation where this might be better than the cases already provided? Might be...

Semi-related: there is some support for this in `dask_tools.py`: https://github.com/pyxem/pyxem/blob/master/pyxem/utils/dask_tools.py#L403, which is for example used for doing `center_of_mass`.

Reminder to self to remove this functionality: https://github.com/pyxem/pyxem/blob/master/pyxem/signals/diffraction2d.py#L1308, since it is superseded by a released HyperSpy functionality.

> I think some generators (generally those that take two complicated pyxem classes) are an asset to the code. After having worked a bit with the generators a bit, I...

Sounds good! I'll have quite a bit more time to contribute when the teaching settles down here, especially to the tidy up part :)

One of the goals of Semantic Versioning, is that the API should not change within a major release. So within 1.x.x, the public "front end" functions which the users are...

The HyperSpy-improved-non-lazy-map pull request in https://github.com/hyperspy/hyperspy/pull/2703 is finally nearing completion. However, the major blocker at the moment is that pull request breaking quite a few of `pyxem`'s functions. This seems...