Magnus Nord comments

Results 135 comments of


                                            Magnus Nord

Large restructure of differential phase contrast class structure

> @magnunor I would rebase this based on PR that just got merged before you go too much further as that PR moves some things around. Done! It was actually...

Large restructure of differential phase contrast class structure

Some more progress, major remaining thing is the documentation. The number of added and deleted lines looks daunting, but most of those are due to files having been deleted with...

Large restructure of differential phase contrast class structure

Two points which would be nice to discuss: ------------------ In this pull request, the `BeamShift.plot` function does this: ```python def plot(self): self.T.plot() ``` I'm not sure if this is the...

Large restructure of differential phase contrast class structure

I switched `BeamShift.plot` over to using `hs.plot.plot_images`, which was a really good idea @CSSFrancis :)

Large restructure of differential phase contrast class structure

> Once https://github.com/pyxem/pyxem/pull/1080 is merged do you want to rebase? If we figure out the testing I can take another pass through and then we can think about what it...

Large restructure of differential phase contrast class structure

I merged the current `main` branch into this branch. -------------- Running `BeamShift.plot()` on a dataset with `` units gives: ```python WARNING | Hyperspy | Axes labels were requested, but one...

Large restructure of differential phase contrast class structure

> @magnunor do you have time to work on this or do you want me to give it a shot. Go for it! My schedule got a bit too full...

Large restructure of differential phase contrast class structure

> @magnunor I fixed the bug causing the tests to fail and adjusted some of the code. Very nice! > We could think about things like: > > 1. Vector...

Large restructure of differential phase contrast class structure

I'll try to get this done today, or most likely tomorrow.

Large restructure of differential phase contrast class structure

> In the past you would use the `to_beamshift` method which would do this for you. But is it good to maybe consider doing it automatically when sending in a...