Mark Larah

Results 80 comments of Mark Larah

FWIW if anyone needs this before it's merged, I used this https://gist.github.com/magicmark/8c2e83eaa59cb8671ef7ce71b2b9db2f (result of this diff) and applied it with [patch-package](https://www.npmjs.com/package/patch-package)

Gotcha, thanks! fwiw in case this helps future readers, my tests for this now look something like this: ```js import httpMocks from 'node-mocks-http'; ... test('forwards cookies', async () => {...

@pcmanus to provide more context on the motivation/my discussion with shane - this came up for us at Yelp, which I've distilled down here https://gist.github.com/magicmark/cbda3eedf1255334caee357fde7680de It sounds like `@cost` could...

👋 adding another data point for wanting this feature (at Yelp) Implementation detail note: having a runtime function that could be invoked to make the decision would be preferable over...

@JPWallhorn do you get any errors/messages in the [console](https://developers.google.com/web/tools/chrome-devtools/console/) at all?

I notice that you're directly calling `ReactDOM.render` - I believe this is unnecessary as per the docs here https://github.com/airbnb/hypernova-react#usage. (Calling `renderReact` will call `ReactDOM.render` underneath the hood.) Side note: I...

https://github.com/airbnb/hypernova/pull/63