jest-how-do-i-mock-x icon indicating copy to clipboard operation
jest-how-do-i-mock-x copied to clipboard

typo in get-platform.test.js

Open da-mkay opened this issue 1 year ago • 1 comments

Hi,

first of all thanks for sharing the information provided in the repo here! 👏

I guess I found a bug/typo. In src/process-globals/tests/get-platform.test.js you write:

Object.defineProperty(process, 'platform', {
    ...Object.getOwnPropertyDescriptor(process, 'property'),
    value: 'foo',
});

But I guess you meant:

Object.defineProperty(process, 'platform', {
    ...Object.getOwnPropertyDescriptor(process, 'platform'),
    value: 'foo',
});

At least, this is what works for me and makes sense in my brain 😋

da-mkay avatar Jan 30 '24 21:01 da-mkay

oh yes....

magicmark avatar Feb 02 '24 20:02 magicmark