Mathias Fredriksson

Results 420 comments of Mathias Fredriksson

Hey, thanks for the PR. I do think we should take a slightly different approach, though. Instead of piggy-backing on `closeMutex` in `writeClose` and potentially introduce deadlocks due to multiple...

> Another note: > > your last commit makes my test (`go test -count=10 ./...`) gives me the "conn_test.go:623: failed to close WebSocket: failed to read frame header: EOF" again...

@FrauElster I pushed a fix for the `failed to close WebSocket: failed to read frame header: EOF` issue. Let me know if you want me to open a separate PR...

Hey @paralin. Thanks for this proposal, the weight reduction is impressive but I believe this is an uphill battle. For instance, in #373 there's a request to introduce `*http.Client` as...

@paralin what you say makes sense but what I'm looking for is concrete use-cases. Code where you're using `websocket` and building for wasm, without importing anything from `net/http`. If I'd...

@SYSHIL sure, feel free to work on this, we'd be happy to accept a PR for the feature!

Thanks for reporting @shukrash. Looks like the protocol definition is wrong in this case, but we can work around it. Would you mind trying out #150 to see if it...

Thanks for the contribution. Personally I'm not a huge fan of this since there are edge cases we can't guard against, for example: ```console ~ ❯ echo -n hi; zsh...

Hi @kpachhai, can you update the import to `github.com/coder/websocket` instead of `nhooyr.io/websocket`? Alternatively you can probably `go get -u` to fix it without updating the import (but forces a version...

Hi, @fortuna. Interesting use-case. From what you describe it sounds like it's somewhat in conflict with [RFC 6455: 5.5.1](https://datatracker.ietf.org/doc/html/rfc6455#section-5.5.1): > If an endpoint receives a Close frame and did not...