Mathias Fredriksson
Mathias Fredriksson
@johnstcn I think we should only operate on a clean repository with the default/configured branch checked out. If a user has local changes or a custom branch checked out then...
If I'm understanding you correct, I'd say yeah we want to do that. Essentially we want to check that the remote of the _currently checked out branch_ matches that of...
Thanks for the PR @ethanndickson! I wanted to see if we're potentially causing a regression with this change and it looks like if read or write is open during Close,...
/ping @dannykopping and @DanielleMaywood in case you can provide context.
@BrunoQuaresma My suggestion is to collapse the build-log on a successful stop, this is plenty indication that we're "done". A button here could toggle show/hide of build log:
@romracer this is great, thanks for the effort you put into this! I don't mind the ping (tbh I need a better system for dealing with my GH notifications 😅),...
Are you using the example as-is? https://github.com/mafredri/cdp/blob/e5a75ebc0b46b7dbf5553fc2ff6f2b11754d65ea/example_test.go If yes, can you try to add logging and show the output? Example here: https://github.com/mafredri/cdp/blob/e5a75ebc0b46b7dbf5553fc2ff6f2b11754d65ea/example_logging_test.go#L49-L52 And finally, what browser/version are you using?
@MarioSimou your usage looks correct. I suspect your browser doesn't support it. What browser and version are you using, and are you running it in headless mode as well?
@MarioSimou another option is that this is being blocked by security settings, see: https://knowledge.workspace.google.com/kb/load-unpacked-extensions-000005962
Alright, please update to v128 (this was added in protocol version r1289136) and make sure to enable the `--enable-unsafe-extension-debugging` flag as per docs: https://pkg.go.dev/github.com/mafredri/cdp#Extensions Although, considering `--remote-debugging-pipe` is mentioned, I'm...