maflcko

Results 182 issues of maflcko

Steps to reproduce: * Build with `integer` sanitizer * `UBSAN_OPTIONS="suppressions=$(pwd)/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1" ./src/qt/bitcoin-qt` * Enter into the RPC debug console: `decodepsbt "cHNidP8BAKOro2MDAwMDA5ggCAAA////CQAtAAD+///1AAAAAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAJAAAAAAAAAAAAAAAAAAAAAAAAAD+///1Zm9ybmV3nWx1Y2vmelLmegAAAAAAAAAAAAAAAAAAAAMKAwMDAwMDAwMDAwMACvMBA3FkAAAAAAAAAAAABAAlAAAAAAAAACEWDQ0zDQ0NDQ0NDQ0NCwEAAH9/f39/fwMAAABNo6P///kAAA=="`

Bug

The test passes on all platforms, such as freebsd, linux, or macos. However, it does not pass on Windows. Temporarily relax it on Windows to avoid wasting resources on manually...

Tests

`Merge` will create several copies unconditionally: * To initialize the args `a`, and `b` * `ret`, which is the merge of the two args So change the code to let...

Refactoring

It seems preferable to assign globals to a class (in this case `ChainstateManager`), than to leave them dangling. This should clarify scope for code-readers, as well as clarifying unit test...

Refactoring

This makes follow-ups easier to review. Also, it makes sense by itself.

Refactoring

It seems that it would otherwise silently skip the rescan for pre-backup used keys that are still waiting to be generated into the keypool? See also #11249

Feature
Wallet

Taken from https://github.com/bitcoin/bitcoin/pull/16116 , as requested here: https://github.com/bitcoin/bitcoin/pull/25748#issuecomment-1205441706

Tests

`LLVMFuzzerInitialize` can be used to initialize deterministic, but expensive global state, which is later used by the target read-only. However, `--timeout` starts counting inside the init function, thus killing the...

The following code will print different output on different compilers: ``` enum Number : uint8_t { FOO = 111, }; int main(){ std::cout

It seems matplotlib can not properly render histograms, when log scale is active for the y-axis and the absolute frequency is smaller than ~2.7, ie. 1 and 2. The Python...