George Kikas

Results 12 comments of George Kikas

Regarding dependencies, in this PR I just added loguru to `requirements.txt`. However there were still some packages which were missing from my local environment (e.g. gooey, pandas). Then I saw...

Currently the logs for errors are very verbose regarding callbacks. Do we want this or should we opt for something shorter? I attach an example below ``` 2024-05-13 13:45:14.880 |...

It can toggled by adding a new logger instance with `diagnose`=0. Backtraces can be also toggled but they are either on or off, I couldn't find a backtrace level For...

The last issue is that `@logger.catch` catches all exceptions and logs them in the loguru format. If the logger is disabled those exceptions do not show for the library user...

Btw a sample log would be something like this with the `verbose` setting: ![image](https://github.com/physiopy/peakdet/assets/74024609/d41250cf-8d65-49f4-814d-70b18dc16ac0) and a sample log without `verbose` ![image](https://github.com/physiopy/peakdet/assets/74024609/cdd329ab-9f8d-423f-8d81-ef49d32c0514)

List of things for this PR: - [x] Add more info logs throughout the functions (not on the workflow as it's outdated for the time being) - [x] Add a...

Here is a look of the logger during a sample "run" of the CLI ![image](https://github.com/physiopy/peakdet/assets/74024609/e2e28494-705d-4d2d-bcb9-39e34da95461)

That's one with the `--verbose` option ![image](https://github.com/physiopy/peakdet/assets/74024609/f414032d-3852-4df2-8e82-6301875c5dcf)

@m-miedema @me-pic @smoia everything listed in [this checklist](https://github.com/physiopy/peakdet/pull/62#issuecomment-2133616706) is completed (+removal of Gooey), and should be ready to merge. Please review

One last change. In some test cases the test was checking if a `UserWarning` was raised. This expects the `warnings` module usage and not the loguru logger. The workaround I...