Jonatan Männchen
Jonatan Männchen
Started working on a PR.
@muhlemmer Thanks for checking the issue. I can't see any difference so far. Has this been rolled out?
(I might have missed a few boxes to check. I just checked what I was certain would already be done.)
> Thanks for creating this checklist @maennchen, it all looks reasonable and should be something we can work towards. > > I have some questions and observations on some of...
The same applies to `defmodule` inside of ExUnit tests. Example: ```elixir defmodule Oidcc.Plug.UtilsTest do use ExUnit.Case, async: false describe "get_refresh_jwks_fun/1" do test "returns client_store.refresh_jwks function when implemented" do defmodule ClientStoreWithRefresh...
Just a little FYI for some context `defmodule` in tests are not uncommon. Even elixir does it: https://github.com/elixir-lang/elixir/blob/32f7646eb4d61d98df9dd9a929e5cf34e12fb33a/lib/iex/test/iex/interaction_test.exs#L263-L267
Summing up my thoughts I shared on Slack: **1. Scope of `otp` purls** * The `otp` purl type was designed to identify **OTP applications**, not entire Erlang/OTP releases. * For...
I also did a tiny change to the flowchart in https://github.com/package-url/purl-spec/pull/472 to better reflect the things stated above.
@tsloughter Yes, it’s listed as optional. This issue is about making sure that optional deps are not fetched / compiled if not needed.
My use case is being able to switch to a different server for Hex entirely. We'll be using that for a security audit on Hex.pm and we'd like to switch...